fix: add missing deviation timestamps #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
leoparente
approved these changes
Jan 16, 2025
|
Go test coverage
Total coverage: 74.0% |
ltucker
approved these changes
Jan 16, 2025
mfiedorowicz
merged commit d6786ec
into
feat-postgres-implementation-and-enhancements
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
diode-serverrepository, specifically focusing on adding timestamp fields to deviation records and updating test cases accordingly. The most important changes include addingIngestionTsandLastUpdateTsfields to the deviation records and modifying test cases to validate these new fields.Enhancements to Deviation Records:
IngestionTsandLastUpdateTsfields to the deviation records in theRetrieveDeviationsandRetrieveDeviationByIDmethods indiode-server/dbstore/postgres/repository.go. [1] [2]Updates to Test Cases:
timeandgithub.com/stretchr/testify/assertimports indiode-server/reconciler/deviation_test.go.IngestionTsandLastUpdateTsvalues to test deviation records inTestRetrieveDeviationsandTestRetrieveDeviationByIDfunctions. [1] [2] [3] [4]IngestionTsandLastUpdateTsfields. [1] [2]